search

hackoregon / civic

The frontend monorepo for the CIVIC platform.
http://civicplatform.org
MIT License
60 stars 26 forks source link

Share functionality should always copy https by default #1204

Closed jaronheard closed 4 years ago

jaronheard commented 4 years ago

Description

If you click the embed option under share link when you're on a http:// connection, it will copy an embed link with http://, which will give you an insecure connection error if you try to embed it somewhere else.

All share links for cards should be https:// by default

Steps to reproduce

http://civicplatform.org/cards/demo-card > then click share link to get https://civicplatform.org/cards/demo-card/embed

Expected result

Should copy link with https

Actual result

Copies link with http

Environment

Production

ynden commented 4 years ago

Hello Jaron, can you assign it to me? I would like to work on it, thanks!

jaronheard commented 4 years ago

@yden063 Assigned! Let me know if you have any questions.

ynden commented 4 years ago

Thanks Jaron, I am going to get familiar with the project first, and then start the coding.