hackoregon / civic

The frontend monorepo for the CIVIC platform.
http://civicplatform.org
MIT License
60 stars 26 forks source link

Replace d3 import with imports from smaller d3 modules in ui-maps #1217

Open jaronheard opened 3 years ago

jaronheard commented 3 years ago

Description

All of d3 gets bundled with @hackoregon/ui-maps, in places where only some of d3 is needed. All places where import * as d3 from "d3"; is used should be replaced with imports of the needed functions from the smaller d3 modules such as d3-geo.

Steps to reproduce

Use create-react-app to start a new project, yarn add @hackoregon/ui-maps, and use a component like PolygonPreview. Then build, and inspect your bundle using source-map-explorer to see that all of d3 is there.

Screenshot of source-map-explorer showing d3 bundles ![image](https://user-images.githubusercontent.com/7065695/92318656-810ac900-efdd-11ea-9817-f90f4a955c51.png)

Expected result

Should only import needed functions from d3-geo

Actual result

Imported all of d3