add kitchen sink - Githubissues

hackoregon / civic

The frontend monorepo for the CIVIC platform.

http://civicplatform.org

MIT License

60 stars 26 forks source link

add kitchen sink #1243

Closed vincegonzalez closed 3 years ago

vincegonzalez commented 3 years ago

Changes:

added kitchen sink markup
added base tw variables based on brand

Todo

create variable conventions

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 34a58e4ddfd1a541836ce40d461efa461a0c2f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vincegonzalez commented 3 years ago

remove non prose elements form kitchen sink
rename kitchen sink to civic prose
apply brand typography to prose (except font size)
add shades of colors to have alternatives

jaronheard commented 3 years ago

The colors variants look really good @vincegonzalez!

I was wondering why the typography was so small in comparison to the @tailwind/typography demo, but then I realized that there are 5 different prose variants for different contexts.

I was thinking that I would add those variants as stories on the CivicProse component, but now I'm thinking I may combine the CivicProse and Typography stories into the Typography story example.

jaronheard commented 3 years ago

For the typography, it doesn't look like our Google Fonts are being loaded in the current Storybook publish, which I will also fix.

I'm also thinking that the thin font weight on the H1 looks out of place now that it's not a big size. Going to try the default and see how that feels.