search

hackoregon / civic

The frontend monorepo for the CIVIC platform.
http://civicplatform.org
MIT License
60 stars 26 forks source link

Improve and standardize size props for LineChart and Scatterplot #586

Open jaronheard opened 5 years ago

jaronheard commented 5 years ago

Is your feature request related to a problem? Please describe. LineChart and Scatterplot both take in a size property, but they have different APIs.

Describe the solution you'd like A solution should satisfy the following:

  1. Consistency between component APIs
  2. Provide an option for LineChart to not show points on on the line (could set size to 0?)
  3. Should be able to scale size based on a data property
bradfordjanice commented 5 years ago

Do the same for the StackedAreaChart component and stories.