search

hackoregon / emergency-response

Simulations, Models, and Visualizations of Portland Fire and Rescue data
11 stars 10 forks source link

Database Data types for fma.fma/fm_api_rollup.fma #88

Closed BrianHGrant closed 7 years ago

BrianHGrant commented 7 years ago

So I believe the fma number (fma column) in these tables is saved as a char field. As such if someone searches for fma 1 vs fma 01 , they will be returned "not found". Can we change these to number fields so the leading 0 will not affect searches?

sky-t commented 7 years ago

I'll fix this!

sky-t commented 7 years ago

@BrianHGrant, converted the fma column to integer in the fma_api_rollup table. Let me know if you need anything else.

BrianHGrant commented 7 years ago

@sky-t ,The fma.fma column needs to be changed to integer as well, causing an error when doing a join.

sky-t commented 7 years ago

Sorry bout that. Check it again.