search

hackoregon / transportation-system-backend

2018 repo for the transportation api backend
MIT License
8 stars 2 forks source link

update to match examplar #46

Open bhgrant8 opened 6 years ago

bhgrant8 commented 6 years ago

So our apis and structure predate work done on the examplar repo. We seem to be stabalizing in terms of project structure and alot of bugs. We may be at a good point to integrate the updates into our backend repos.

znmeb commented 6 years ago

Except on Windows 10 Home, yeah

nam20485 commented 6 years ago

Question- Since we are talking about updating the exemplar and I have the basic travis config working (deploy/build.test) in my disaster-resilience-backend, do we want to have me port those changes over to the backend-exemplar? I have a very good understanding of what it would take and could put together a PR that we could review. Adding the changes in would add a lot of value to the exemplar pattern, because the result would be a quickstart app and repo that has everything in it needed to deploy to travis and build the containers, straight "out-of-the-box" with no more config than was already needed or present in the repo (no extra config to have travis deployment work).

@MikeTheCanuck (adding Mike to the thread for his input)

MikeTheCanuck commented 6 years ago

hells yeah @nam20485 definitely fire up a PR - we can always contribute to it or add comments and reviews to get it to align with where we need to go.

I've been adding bits to the examplar-updates branch of this repo to help get the Travis pipeline to behave as we'd need it to, and outside of some IAM setup (and an unexpected bug I'm about to file), this should also be a good comparison for you.

nam20485 commented 6 years ago

Cool. I will look at your branch and then create a PR to port my changes over.

bhgrant8 commented 6 years ago

+1 on opening the pr to bring in your code to the examplar. this branch was mostly to update our team api to current standard, then needed to figure out some of our testing strategy, which differs a bit based on the the db instances we are connecting to.

kiniadit commented 6 years ago

@bhgrant8 looks like the backend exemplar changes have stabilized. I can work on getting the changes ported into the transportation backend though I'm not sure what the best practice is. It wouldn't be too hard to simply delete the current repo and recreate the transportation API using the backend exemplar as a template. I think this might be a better strategy that trying to cherry-pick changes. what do you think?

nam20485 commented 6 years ago

In my disaster-resilience-backend repo, I did try setting the backend-examplar-2018 as an upstream remote and then merge in the changes to my repo. The process was entirely manual, that is, I had to diff every file in the repo (even ones that didn't have any updates that I wanted) and either cherry-pick the changes in the file I wanted, or discard all changes to the file if it did not contain any interesting changes from the backend-examplar.

In short, it was a pain in the ass and I did not gain anything by doing it in this manner. Most likely is that I will not do it again this way.

I think there is probably not going to be an "easy" straightforward way to port changes from the backend-examplar repo to our respective "forked" child repos. At least not one that I am currently aware of.

I would recommend either manually hand-porting the changes into your repo, or as mentioned above, deleting the repo, re-generating a quickstart app, and then adding any Django app modifications (e.g. API or models) back in.

If anyone has any better or other ideas, please add them to this thread.