kartminer7 v2: use nimdsphax

hacks-guide / Guide_3DS

A complete guide to 3DS custom firmware, from stock to boot9strap.

https://3ds.hacks.guide/

MIT License

1.57k stars 315 forks source link

kartminer7 v2: use nimdsphax #2321

Closed lilyuwuu closed 1 year ago

lilyuwuu commented 1 year ago

But what if I were to take #2305 and disguise it as my own #2319?

Adds kartminer7, now with extra nimdsphax. Thank god, that last PR was getting to be a nightmare in terms of guide routing.

In particular:

Alternate Exploits and Seedminer (Alternate) reworded accordingly to add Mario Kart 7
B9S-kartdlphax now only does menuhax67 + nimdsphax
New page: B9S-Kartminer7, which uses includes for the second half since it's the same as B9S-kartdlphax
Adjust site navigation accordingly
Adjust progress table accordingly

TheMasterOfMike commented 1 year ago

Not going to specifically mark a review spot, but the kartdlphax page in general still has mentions/links of unSAFE_MODE, which shouldn’t be relevant anymore due to nimdsphax

TheMasterOfMike commented 1 year ago

GitHub refuses to let me comment on specific lines for some reason (thanks GitHub) but lines 10, 64, and 80 (of the state of the file in the PR) still have unSAFE_MODE mentions that we’re not resolved in f985560

TheMasterOfMike commented 1 year ago

I think you missed line 10 still (unfortunately)

TheMasterOfMike commented 1 year ago

Other than that, everything seems to look fine based on me reading through everything (and yes, I think you got all the unSAFE_MODE's, thankfully)