search

hacks / hacks.github.io

The website for NU Hacks, a weekly social event for hackers and makers
https://nuhacks.io
16 stars 14 forks source link

New site redesign #39

Closed edward-shen closed 5 years ago

edward-shen commented 6 years ago

This is written using Jekyll. Here are some preview images if you don't have jekyll installed: first screen second screen third screen

It's also fully responsive!

kylesferrazza commented 6 years ago

@edward-shen and I are also interested in helping maintain the website if you need it

edward-shen commented 6 years ago

I'd like to add more mentors, but idk who to add. Alice has already graduated from NU, so i was wondering who to add as replacements--that is, of course, unless she wants to stay on :D

kylesferrazza commented 6 years ago

@jaronoff97 @aliceyoung9

aceyoung9 commented 6 years ago

1) plx remove me from mentors list. 2) Let people fork and add themselves. Ask for contribs by standing on a table at an irl hacks meeting, or asking on fb, i guess.

jaronoff97 commented 6 years ago

@kylesferrazza looks cool! let's talk about it at the next hacks meeting!

kylesferrazza commented 6 years ago

@jaronoff97 ok!!

edward-shen commented 6 years ago

I'm pending feedback from a designer friend -- Initial thoughts: she says the second and third page have a little too much whitespace in the middle, and I'm inclined to agree, especially with the third page. Do we have any more content we can throw onto it?

She also complained about the line length for the second page -- we can fix this by increasing the padding in .container.

I can work on this @ hacks thursday, but i'll get there around 10-11.

edward-shen commented 6 years ago

I should just also casually mention that perhaps the mentors webpage also should be updated -- @aliceyoung9 you're the first person on that!

aceyoung9 commented 6 years ago

@edward-shen I don't think any current Hacks member has assumed ownership over maintenance for that repo, and I had assumed someone else was going to publish the past month's worth of changes....but that didn't happen. Just pushed everything up.

caccavale commented 6 years ago

Huge fan of the layout, might have to change some of the text justification but damn, this is keep it stupid simple and I love it. +1 from me.

Should mention: don't worry about the content too much we will update that.

edward-shen commented 6 years ago

I've changed a little on the third page, as well as made the padding larger. This should help. I've also made the padding a little larger. I've made the slogan on the first page more responsive.

New third page: image

edward-shen commented 6 years ago

I've just noticed that by using this, we can make it so that the mentors page and the data on the landing page can be sync'd. Only side effect is that the url would be hacks.io/mentors rather than mentors.hacks.io.

Let me or @kylesferrazza know if you want this implemented.

kylesferrazza commented 5 years ago

@dmelcer9 would it help if I resolved the conflicts?

dmelcer9 commented 5 years ago

@kylesferrazza I resolved the conflicts and pushed, but it is not showing up because github is down.

edward-shen commented 5 years ago

I think there was an issue with the merge; it looks like you only merged the last commit of this PR and committed the rest of the PR as your own.

kylesferrazza commented 5 years ago

Nope, it's all there

dmelcer9 commented 5 years ago

@edward-shen All the stuff after fa16cdd "Update meeting location" was my own, I needed to do some merge weirdness because the two branches had diverged significantly and a normal merge would just screw up a lot of things. All of the stuff in the old branch was written in raw html while the redesign uses md and Jekyll so I copied and converted any changes made to the old site manually (mostly the code of conduct) and updated a few things on the site redesign like email addresses and removing the discord link.

The reason it isn't showing up is because Github globally paused all gh-pages updates.

edward-shen commented 5 years ago

Your'e right. I wasn't aware of Github issues. My bad.

edward-shen commented 5 years ago

We should also be able to close #27 now right?

dmelcer9 commented 5 years ago

Pretty sure it got auto-closed by the merge, it doesn't appear on "open PRs" anymore.

edward-shen commented 5 years ago

27 is an issue; is #44 still applicable?

dmelcer9 commented 5 years ago

The first 3 checkboxes are solved by this. What do you want to replace the 4chan joke with?

edward-shen commented 5 years ago

"We realize that people really prefer tabs, 2 spaces, or 4 spaces. We propose using 3-character soft tab as a solution"

"TODO: Allan pls add detail"

"Please refrain from tapping the glass. Instead, drink enough to hit Ballmer's Peak."

"Are you sure Systems kids aren't intentionally fork bombing the servers?"

"Are you sure you're sure?"

"Praise our lord and savior Tuck/Blerner/Matthias/Recurrent Neural Networks. Wait, no-"

"We promise better uptime than Youtube!"

These were some (terrible) jokes thought up during a honor seminar class.