search

hackslash-nitp / cura

An application, made with Flutter, that acts as a platform for the charity institutions (old-age-homes, orphanages) to connect with the people
7 stars 14 forks source link

Fixed Named Routing #56

Closed Devank-Sachdeva closed 1 year ago

Devank-Sachdeva commented 1 year ago

Issue https://github.com/hackslash-nitp/cura/issues/52 Added all the routing stuff to a new file RouteGenerator.dart to not make main.dart messy also added a file called StringScreenArguments.dart which is used in sending Multiple arguments on pushNamed routes.

All the route names are specified in the class itself with a routename property (which makes changing them easier by changing routename at only one place)

Fixed conflicts with previous pull request opened by me

Devank-Sachdeva commented 1 year ago

Thank you for the opportunity 😇

Devank-Sachdeva commented 1 year ago

@RitwikSingh28 I just noticed the import file lines in main.dart, org_chats_menu.dart, user_chats_menu.dart were not refactored. Can u reopen this pull request or shall make a new one ?

RitwikSingh28 commented 1 year ago

@Devank-Sachdeva Yes, I just noticed it now as well. Please kindly make the necessary changes and create a new PR.

Devank-Sachdeva commented 1 year ago

@RitwikSingh28 Added new PR https://github.com/hackslash-nitp/cura/pull/57 can u review it 😀

RitwikSingh28 commented 1 year ago

Sure...