search

hacksparrow / safe-eval

Safer version of eval()
257 stars 37 forks source link

[CVE-2017-16088] Sandbox Breakout (Critical Security Fix) - context clear #13

Closed kaue closed 5 years ago

kaue commented 5 years ago

LGTM @hacksparrow

kaue commented 5 years ago

I think i fixed most of the issues reported by @cpcallen at v0.4.2 @cpcallen if you can find another way to break the vm context please share, thanks for the detailed report.

hacksparrow commented 5 years ago

@kauegimenes we can land this, please squash the commits messages into a single descriptive one.

kaue commented 5 years ago

@hacksparrow LGTM

kaue commented 5 years ago

@hacksparrow can you merge this?

kaue commented 5 years ago

start maintaining your packages @hacksparrow, another week without a reply from you

kaue commented 5 years ago

test fails because

fatal: Couldn't find remote ref refs/pull/14/merge
The command "eval git fetch origin +refs/pull/14/merge: " failed. Retrying, 2 of 3.

this is not related to the PR code.