hacksu / khe-revengeance

The website for KHE staff and attendees used for KHE 2024.
https://khe.io/
0 stars 1 forks source link

More robust storage of resumes #45

Open Struck713 opened 8 months ago

Struck713 commented 8 months ago

Instead of passing a Base64 string around, create an Express route where we can upload (and later request for viewing) resumes https://github.com/hacksu/khe-revengeance/blob/e0d461e97f05fb84e60167d09573725e68e29b18/server/rpc-definitions.ts#L355-L372

toBeOfUse commented 7 months ago

This is noble. The base64 string method was the easiest way to set up uploads quickly because I could pass the string to a remult "backend method" instead of setting up an actual Express route/endpoint, but it's non-standard and inefficient