hackthenorth / hackthenorth-android

Hack the North Android App (2014 Version)
26 stars 2 forks source link

New APK release feedback #18

Open KartikTalwar opened 10 years ago

KartikTalwar commented 10 years ago
srcreigh commented 10 years ago
moezbhatti commented 10 years ago

@KartikTalwar

Can we have the gear logo with the htn text in the header bar (center aligned)

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

In the prizes section, can the Prizes heading be paragraphs as well (instead of bullets only)?

What do you mean by this? Aren't the prize names all going to be less than one line anyway?

Can we see the team's contact info demo

I'll be working on this as soon as I get a chance

wrt updates, I think the focus should be reversed. Currently the person who made the updates is bigger (font) than the message. It'll be literally just us posting messages so you'll keep seeing the first name. Can we take away all attention from the owner and make the actual post our focus.

Very good point. I've got an idea in mind for an alternate layout, so I'll implement that shortly as well

srcreigh commented 10 years ago

What's your idea for the alternate layout, Moez? Keep in mind that we want to remain consistent with iOS with minimal work at this point.

KartikTalwar commented 10 years ago

@srcreigh @moezbhatti

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

That's fair, The reason I mentioned it was because the padding on the left makes it seem weird (even though its aligned with the U in Updates). So either we made just the text center or add the logo on the left. I was trying to normalize it with spacing on left and right of the bar

it's doing fuzzy string matching on all the relevant data for each mentor

I asked because, if I type in 'sdfdsvcasvrg' I still see results. So should the expected behaviour be no results or they get ranked anyway?

What do you mean by this? Aren't the prize names all going to be less than one line anyway?

So a prize card has 2 headings, the company name (paragraph body) and then Prizes (list body) wanted to know if the prizes can also be a sentence/paragraph

Very good point. I've got an idea in mind for an alternate layout, so I'll implement that shortly as well

:+1:

srcreigh commented 10 years ago

I asked because, if I type in 'sdfdsvcasvrg' I still see results. So should the expected behaviour be no results or they get ranked anyway?

Oh, yeah. I can have things that rank below a certain threshold just not show up at all, which should fix this problem.

srcreigh commented 10 years ago

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

That's fair, The reason I mentioned it was because the padding on the left makes it seem weird (even though its aligned with the U in Updates). So either we made just the text center or add the logo on the left. I was trying to normalize it with spacing on left and right of the bar

Maybe it'll look better if the left margin of the text is the same as the bottom / top margin.

sitefeng commented 10 years ago

Pretty solid design

NimaVaziri commented 10 years ago

Just tried the latest release. First impression: awesome, well done!

srcreigh commented 10 years ago

Thanks :)