search

hacktivist123 / goignore

A lightweight CLI tool for generating .gitignore file in your project. Built with Go and ❤️
MIT License
29 stars 6 forks source link

added fix for language detection #20

Closed chuksgpfr closed 1 year ago

chuksgpfr commented 1 year ago

This PR adds a fix for the language detection feature.

chuksgpfr commented 1 year ago

@hacktivist123 I have tested. You can go ahead and test. If you have any features to add. Any I can help with

hacktivist123 commented 1 year ago

@quamejnr check this out and let me know what you think since this relates to your PR

quamejnr commented 1 year ago

Yeah it looks good, wanted to first implement something like that but changed my mind later. But in the usecase that's being proposed. considering both .js files and .ts files all have the same gitignore file, I don't quite see what change that will introduce, unless there will be an introduction of a typescript exclusive gitignore file

hacktivist123 commented 1 year ago

Yes, there will actually be a typescript specific file soon.

So I’m going to merge this, then you can rebase your current PR and see if you can refactor your tests a bit. Is that fine with you? @quamejnr

quamejnr commented 1 year ago

Yes that's fine, if the merge goes well, I think the tests will work fine or is there something else you think would change?

hacktivist123 commented 1 year ago

Not sure, but let's see how it goes