hacktons / convex_bottom_bar

A Flutter package which implements a ConvexAppBar to show a convex tab in the bottom bar. Theming supported.

https://bar.hacktons.cn

Apache License 2.0

801 stars 150 forks source link

fix tabController.animateTo() bug when new index > 1 tab away #176

Closed qixotic closed 2 years ago

qixotic commented 2 years ago

Hi, this should fix #171, which was a bug introduced with the change in pull #61 to address an earlier issue #59.

59 appears to have been fixed in the framework itself with https://github.com/flutter/flutter/pull/88878 (in part to address TabController issue https://github.com/flutter/flutter/issues/88875) as of Flutter 2.8 (https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-2.8.0).

What do you think?

Example video of the bug, as seen in the example code: https://user-images.githubusercontent.com/854794/182205397-fd91d5e5-c4ae-422c-8454-bed229104e61.mov

S-ecki commented 2 years ago

@avenwu I am also currently facing this issue and would greatly benefit from this PR being merged!