[Intro to iOS] Project 3 (Twitter) - Review my app

[jontsai]

Here's my submission for Project 3.

https://github.com/jontsai/htk-ios-Twitter/commit/6d3007c528572538f3062f9980ea3e5ddbeea711

All required stories done except for Compose View and Tweet Details View, which are in progress. I'll continue working on finishing those up and adding more polish.

/cc @thecodepath @timothy1ee

[timothy1ee]

Yikes, looks like you're pretty far behind here. What's the status of this assignment?

[jontsai]

Hey,

Just resubmitted with all the required and optional user stories completed.

https://github.com/jontsai/htk-ios-Twitter/tree/44a57213f5d83a67397e76e83c33a60b3ee81d9c

I'll give more details over email RE: the delay--sorry! :(

/cc @thecodepath @timothy1ee

[timothy1ee]

Jon, excellent work on this homework, nice job tackling the optionals. Hopefully, things with iOS are starting to come together for you. In the feedback below, I go through a checklist, and if things look good, I'll mention it to let you know you're on the right track, or I'll provide some feedback.

• TwitterClient and models look good. In production, there would be more validation to be robust to unexpected values, but in this homework it was fine to assume a well behaved API.
• You should move your assets to Images.xcassets.
• TweetCell looks good, good use of property observers, you can make the view properties private for more encapsulation. Nice job adjusting the Auto Layout constraint constants. If you want to implement reply, you can use a custom delegate for the TweetCell so the view controller can present the compose view.
• Good job with infinite loading.
• After composing a tweet, you should use a protocol (or a notification) to publish that there's been a new tweet instead of assuming there is a TweetsViewController in the navigation stack.
• You have some warnings, but in general Auto Layout constraints look good.