Closed onyxfish closed 12 years ago
I'm not sure about LOC, but tablesorter is great. I've used it many times. Interested to see what you came up with.
Tablesorter is the one with 1k LOC and eval. I'm sure it has great uses on complex tables, but for something as simple as our table, it's overkill.
Point of order: which is overkill--using the thing which already works and takes 5 minutes to implement or the thing which is unproven and takes two hours to code? :-)
C
On Thu, Apr 12, 2012 at 1:50 PM, Joseph McCullough reply@reply.github.com wrote:
Tablesorter is the one with 1k LOC and eval. I'm sure it has great uses on complex tables, but for something as simple as our table, it's overkill.
Reply to this email directly or view it on GitHub: https://github.com/hacktyler/hacktyler-artmap/issues/34#issuecomment-5097863
I actually tried table sorter and couldn't get it to work. Also, it comes up with so much enabled by default it would've taken a decent amount of documentation reading to get the bare minimum that I wanted. You raise a good point, but I think there needs to be a solution for super super simple table sorting. This is why I'm calling my plugin StupidTable ;P
Fair enough, I'm all for simplicity. :-)
C
On Thu, Apr 12, 2012 at 1:55 PM, Joseph McCullough reply@reply.github.com wrote:
I actually tried table sorter and couldn't get it to work. Also, it comes up with so much enabled by default it would've taken a decent amount of documentation reading to get the bare minimum that I wanted. You raise a good point, but I think there needs to be a solution for super super simple table sorting. This is why I'm calling my plugin StupidTable ;P
Reply to this email directly or view it on GitHub: https://github.com/hacktyler/hacktyler-artmap/issues/34#issuecomment-5097993
Let me know what you think. Feel free to leave an issue on the Stupid Table repo :P
Merged and closed, thanks Joseph!
I wrote my own jQuery plugin for the table sort because I couldn't find one under 1000 lines of code (and one of them was using eval, wtf?). I'll be pushing this soon