search

hackwaly / ocamlearlybird

OCaml debug adapter
MIT License
208 stars 23 forks source link

Support 4.9.0 / 4.10.0 #23

Closed pjhampton closed 3 years ago

pjhampton commented 4 years ago

Hi @hackwaly

Would it be possible to support base compiler versions 4.9.0, & 4.10.0 Thanks in advance for your consideration.

$ opam install earlybird
The following dependencies couldn't be met:
  - earlybird → ocaml < 4.08
      base of this switch (use `--unlock-base' to force)

No solution found, exiting
hackwaly commented 4 years ago

I'm sorry that I've tried that. It's not an easy thing. And now I have not enough time to adapt it to 4.9.0 & 4.10.0

pjhampton commented 4 years ago

Hi @hackwaly

I might fork. Can you let me know what the problems were if you remember?

hackwaly commented 4 years ago

Hi @hackwaly

I might fork. Can you let me know what the problems were if you remember?

One interface has breaking changed. So some logic of my code not works.

EduardoRFS commented 3 years ago

4.09 is reasonable I have it working

https://github.com/EduardoRFS/ocamlearlybird/tree/fold-values-workaround-4.09

hackwaly commented 3 years ago

4.09 is reasonable I have it working

https://github.com/EduardoRFS/ocamlearlybird/tree/fold-values-workaround-4.09

Awesome works!

ZZYSonny commented 3 years ago

@EduardoRFS Any chance this workaround is merged or updated to opam?

Now I can dune build to build it, but it compiles to a dynamic linked 1KB binary and I cannot move it to opam switch path. Just found I was building the original version under 4.07.1.

It is a bit hard to get all dependency without opam and I am getting the this error in building the workaround version.

zzysonny@ZZY-G14:~/Code/ocamlearlybird$ dune build
File "ocaml_debug_adapter/inspect.ml", line 194, characters 6-16:
Error: Unbound constructor Env.Aident
Done: 123/141 (jobs: 1)
hackwaly commented 3 years ago

Hello, everyone in this thread. Good news: earlybird now has OCaml Software Foundation financial support. I will solve this issue soon.

hackwaly commented 3 years ago

4.11 support is released. Do you still need 4.09 or 4.10?

EduardoRFS commented 3 years ago

I really want 4.10, especially as it's the oldest version supported on the new Mac ARM with the M1 SoC. It will take a time so that we can start using 4.12, but 4.11 doesn't support macOS ARM. I'm also developing for Android + iOS using 4.10

hackwaly commented 3 years ago

@EduardoRFS I'm sorry for that 4.10 support need lots works todo. It may come after 4.12 released. I'm not sure if it's worth while.

hackwaly commented 3 years ago

@EduardoRFS 4.12 Is expected to be released in a week. https://discuss.ocaml.org/t/ocaml-4-12-0-first-release-candidate/7294

hackwaly commented 3 years ago

@EduardoRFS @pjhampton 4.12 support has been released. I you still need 4.09/4.10 support. Please reopen this issue.