cdaringe commented 2 years ago

problem

no extension logging
- i have more than one issue getting the debugger working. having logging in place really helped me narrow down where debug launch issues where originating
the bytecode detection logic was ok, but i noticed it was possibly swallowing errors and simply returning false if any logic failed within the try {} block
during debugging, I could not see output from ocamlearlybird, as it's a VSCode managed process, but I had suspicion it may be crashing

solution

use the vscode extension logging provider

improve error handling case
add a configuration setting, "ocamlearlybird.connectToLocalDebugAdapterServer", which simply as implemented, just connects to earlybird on localhost:4417, vs launching an instance from VSCode for DAP. This helped me identify #36 ..., which really was two problems, the primary one being my copy of jsoo segfaulting 😆
...and 😬 😬 😬 , I accidentally ran prettier on VSCode project. In case you are not aware, prettier is the ocamlformat of JS. I am willing to undo the prettier format, but there is not an explicit style guide or formatter listed for the JS. Much like OCaml is all in on ocamlformat, so too do i like to "never discuss" formatting in changesets. Given that I did it and it's just a single file, I added prettier to devDeps in case you are interested in adopting it? Let me know

hackwaly commented 2 years ago

You could build extension on your machine and debug to addressing what the problem.

cdaringe commented 2 years ago

Yes, that is where I made this changeset. I’d suggest that emitting log output (local to the extension panel) is a best practice regardless. What do you think? For instance, I’ve used the output panel from ocaml platform ext to discover problems I had with the LSP. I used output last week to discover a bug with a JS extension where the module resolution was not correctly implemented. Logs are quietly tucked away in the extension panel viewer, there only when you need them

hackwaly commented 2 years ago

@cdaringe Is this PR ready to merge?

cdaringe commented 2 years ago

oh, greetings. yes, i think it is 👍 . i was just in the process of adding additional documentation to the changeset.

hackwaly commented 2 years ago

OK. Call me if you think we can merge it.

---Original--- From: "Christopher @.> Date: Sun, Oct 31, 2021 10:20 AM To: @.>; Cc: @.**@.>; Subject: Re: [hackwaly/ocamlearlybird] feat: add extension logging, extfeatures (PR #35)

oh, greetings. yes, i think it is 👍 . i was just in the process of adding additional documentation to the changeset.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

cdaringe commented 2 years ago

wooo hoo! ocamlearlybird just helped me track down a bug i've been looking for for >1 week :) i used this extension branch the whole time :) i think we're g2g!

hackwaly commented 2 years ago

@cdaringe You are welcome to add prettier into this project

cdaringe commented 2 years ago

done, if you’re good I’m good :)

hackwaly / ocamlearlybird

feat: add extension logging, improve extension features #35

problem

solution