Closed cdaringe closed 2 years ago
You could build extension on your machine and debug to addressing what the problem.
Yes, that is where I made this changeset. Iβd suggest that emitting log output (local to the extension panel) is a best practice regardless. What do you think? For instance, Iβve used the output panel from ocaml platform ext to discover problems I had with the LSP. I used output last week to discover a bug with a JS extension where the module resolution was not correctly implemented. Logs are quietly tucked away in the extension panel viewer, there only when you need them
@cdaringe Is this PR ready to merge?
oh, greetings. yes, i think it is π . i was just in the process of adding additional documentation to the changeset.
OK. Call me if you think we can merge it.
---Original--- From: "Christopher @.> Date: Sun, Oct 31, 2021 10:20 AM To: @.>; Cc: @.**@.>; Subject: Re: [hackwaly/ocamlearlybird] feat: add extension logging, extfeatures (PR #35)
oh, greetings. yes, i think it is π . i was just in the process of adding additional documentation to the changeset.
β You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
wooo hoo! ocamlearlybird
just helped me track down a bug i've been looking for for >1 week :) i used this extension branch the whole time :) i think we're g2g!
@cdaringe You are welcome to add prettier into this project
done, if youβre good Iβm good :)
problem
false
if any logic failed within thetry {}
blockocamlearlybird
, as it's a VSCode managed process, but I had suspicion it may be crashingsolution
"ocamlearlybird.connectToLocalDebugAdapterServer"
, which simply as implemented, just connects toearlybird
onlocalhost:4417
, vs launching an instance from VSCode for DAP. This helped me identify #36 ..., which really was two problems, the primary one being my copy ofjsoo
segfaulting πprettier
is theocamlformat
of JS. I am willing to undo the prettier format, but there is not an explicit style guide or formatter listed for the JS. Much like OCaml is all in onocamlformat
, so too do i like to "never discuss" formatting in changesets. Given that I did it and it's just a single file, I added prettier to devDeps in case you are interested in adopting it? Let me know