hackwaly / ocamlearlybird

OCaml debug adapter
MIT License
208 stars 23 forks source link

<abstr> type could be perhaps described more accurately #9

Closed villesau closed 11 months ago

villesau commented 5 years ago

Looks like <abstr> is used when type information is hard to retrieve. looks like path has some more info about the <abstr> type. e.g in this case cx has type Context when attaching debugger on line https://github.com/hackwaly/ocamlearlybird/blob/master/ocaml_debug_adapter/inspect.ml#L367

There might be even more information that could be shown in debugger. I think that cx in this case has some data in it too, but only <abstr> is shown. this is how cx looks like: https://github.com/facebook/flow/blob/master/src/typing/context.ml

screenshot 2018-12-20 at 0 44 55
villesau commented 5 years ago

I think that in this case the <abstr> cx type is actually record. @hackwaly do you have a plan how to implement support for that?

hackwaly commented 5 years ago

I know this issue. And I need what to reproduce it. Or you can give me simpler code (eg, only one main.ml) other than flow codebase to debug?

villesau commented 5 years ago

@hackwaly unfortunately I don't have simpler code base for you :/ But I think that it actually happens with ocamlearlybird as well but i'm not 100% sure.

Here are debugging instructions for Flow: https://github.com/facebook/flow/issues/4181#issuecomment-447596374 and here setup instructions: https://github.com/facebook/flow#building-flow

If you put breakpoint in flow_js.ml to any place that uses cx variable, you see the problem.

hackwaly commented 11 months ago

superseded by https://github.com/hackwaly/ocamlearlybird/issues/52