search

hackwaly / vscode-ocaml

An extension for VS Code which provides support for the OCaml language.
MIT License
170 stars 26 forks source link

Fix 'as' coloration if type constraint contains 'as' #93

Closed maelvls closed 7 years ago

maelvls commented 7 years ago

Example:

let foo (astast:ast) = ()

then both occurences of 'as' in 'astast' are picked as keywords.

I saw that the pattern on as had been duplicated as part of the issue "better syntax highlighting with dracula theme" in #49. That said, I don't really grasp the necessity for this duplicate pattern ('as' is already defined L378). I am sure that you had an excellent reason for adding this pattern! 😁

capture d ecran 2017-05-17 a 09 45 35

hackwaly commented 7 years ago

I forget why I added duplicated as pattern, but the issue you pointed could be fixed by add \b surround as.