Better rendering of `let`s

hackworthltd / primer-app

Primer's React frontend application.

GNU Affero General Public License v3.0

4 stars 0 forks source link

Better rendering of `let`s #24

Closed dhess closed 6 months ago

dhess commented 3 years ago

Placeholder for now. @annedino4 will work on a few ideas.

annedino4 commented 3 years ago

Please see the designs here and below.

Design 1

Design 2

Design 3

Feedback would be appreciated. Feel free to play around with the designs if the above doesn't look right.

dhess commented 3 years ago

Cool, thanks!

I think design 1 is the most compatible with our current design. I'm not sure how easy it would be to implement, however. @georgefst any thoughts?

I'll give the other designs some more thought. I imagine they're not feasible to implement in time for demos or initial testing, in any case.

georgefst commented 3 years ago

I'm not sure how easy it would be to implement, however. @georgefst any thoughts?

I haven't actually done much with the tree-rendering code, but yes I would I assume that would be easiest. Perhaps similar in implementation to hackworthltd/vonnegut#384.

It's my preferred option anyway. Unless we decide to abandon Haskell-style syntax here entirely.

dhess commented 3 years ago

It's my preferred option anyway. Unless we decide to abandon Haskell-style syntax here entirely.

@brprice have discussed (offline) the possibility of representing lets as canvases. This would especially be useful for letrecs, but might still have some value for even single lets.

dhess commented 3 years ago

I'm reasonably happy the changes introduced in hackworthltd/vonnegut#805. I think we can still do better, but this is probably now a matter for Primer and an overall tree rendering rethink once we move to something like d3js.

dhess commented 2 years ago

@annedino4 I think we should tackle this next, after the match with design work is finished.