hackworthltd / primer-app

Primer's React frontend application.
GNU Affero General Public License v3.0
3 stars 0 forks source link

Should we not draw a red ring around non-empty holes? #80

Open dhess opened 3 years ago

dhess commented 3 years ago

(This comes from @annedino4's User Research Report Round 2, issue number 1.)

In https://github.com/hackworthltd/vonnegut/pull/737, we decided to draw a red ring around holes (including non-empty holes) to draw the student's attention to missing parts of the program. Initial testing indicates that when students see a non-empty hole, they immediately think they've made an error, which is sometimes true, but not always. Primer of course cannot tell the difference, so should we not draw a red ring around non-empty holes?

The red outline around empty holes seems OK, because those are generated automatically and not directly as the result of a student's action, therefore perhaps they're less likely to think of these as errors, and simply as parts of the program that need to be filled in.

dhess commented 3 years ago

As a side note, perhaps we should actually render annotations that are automatically inserted by Primer with a red ring or other "error" indication, since they're nearly always not what you want and therefore are a very good indicator that the student is probably on the wrong track?

@brprice what do you think?

dhess commented 2 years ago

~This has been designed and agreed elsewhere. I'm closing this.~ Never mind, this is currently in progress.