hackworthltd / primer

A pedagogical functional programming language.
GNU Affero General Public License v3.0
15 stars 1 forks source link

`check-hls` fails on `aarch64-darwin` in recent `haskell.nix` versions #753

Open dhess opened 2 years ago

dhess commented 2 years ago

It's been broken for at least a week, possibly more:

https://buildkite.com/hackworthltd/primer/builds/2215#0183ff38-5fa1-49ec-8892-de9f67aa40b5

brprice commented 2 years ago

Note that since it was introduced via nix in #631 we only run check-hls on aarch64-darwin (as it is broken on linux #632). Can you check whether fails on other platforms due to this issue or #632? Does the nix build pass locally?

This may have something to do with #628 since the log has a warning

2022-10-22T10:23:59.104137Z \| Warning \| No [cradle](https://github.com/mpickering/hie-bios#hie-bios) found for primer-rel8/test/Test.hs.
--

You should ignore this message, unless you see a 'Multi Cradle: No prefixes matched' error.

and the error is indeed such:


Hidden:   no

Range:    1:1-2:1

Source:   cradle

Severity: DsError

Message: 

  Multi Cradle: No prefixes matched

  pwd:

  /private/tmp/nix-build-check-hls-git-6423a4bde4abece2518e6aa60a48c84d88e54706.drv-0/primer-src

  filepath:

  /private/tmp/nix-build-check-hls-git-6423a4bde4abece2518e6aa60a48c84d88e54706.drv-0/primer-src/primer-service/src/Primer/Pagination.hs

  prefixes:

I wonder if reverting that commit would fix it? (Probably not a straight revert, I suspect it may need some changes also). [Ah, I see this is the content of your related commit that has landed on main]

dhess commented 2 years ago

FYI, it does not pass locally on aarch64-darwin, same behavior as in CI.

dhess commented 2 years ago

A couple of clarifications:

I've left this issue open despite https://github.com/hackworthltd/primer/commit/27d94e20cb85479c0338aaa2b3d0c5ffbc6d773b because that commit shouldn't be necessary (and didn't used to be). Once this is fixed upstream, we can close this issue.