hacl-star / hacl-star

HACL*, a formally verified cryptographic library written in F*
Apache License 2.0
1.6k stars 161 forks source link

Import AES-CTR32 modules from pnmadelaine_aes branch and add NI proofs #919

Open mamonet opened 3 months ago

mamonet commented 3 months ago

This PR imports AES-CTR32 modules from pnmadelaine_aes branch and adds proofs for NI functions.

github-actions[bot] commented 3 months ago

[CI] Important! The code in dist/gcc-compatible, dist/msvc-compatible, and dist/wasm is tested on cryspen/hacl-packages. dist is not automatically re-generated, be sure to do it manually. (A fresh snapshot can also be downloaded from CI by going to the "artifacts" section of your run.) Then check the following tests before merging this PR. Always check the latest run, it corresponds to the most recent version of this branch. All jobs are expected to be successful. In some cases manual intervention is needed. Please ping the hacl-packages maintainers.

mamonet commented 2 months ago

The fact that the arguments to the (unverified) macro glue were in the wrong order makes me... slightly nervous

The order of arguments were flipped in the implementation side of F* code, but it doesn't meet the argument order in spec. To make the order consistent, I could either change the order for impl and spec or in libintvector.h I went for the later.

franziskuskiefer commented 2 weeks ago

@msprotz @karthikbhargavan what's the state here?