Vectorised SHA3 includes in non-vectorised code - Githubissues

hacl-star / hacl-star

HACL*, a formally verified cryptographic library written in F*

Apache License 2.0

1.6k stars 161 forks source link

Vectorised SHA3 includes in non-vectorised code #939

Closed franziskuskiefer closed 2 months ago

franziskuskiefer commented 2 months ago

The new vectorised SHA3 code is included in places where it shouldn't, i.e. where no simd256 is available.

For example (why is this included in SHA2 anyway?) https://github.com/hacl-star/hacl-star/blob/81f0e3bb461fc7d0102211dc9fa5be03951cd654/dist/gcc-compatible/Hacl_SHA2_Types.h#L38 https://github.com/hacl-star/hacl-star/blob/81f0e3bb461fc7d0102211dc9fa5be03951cd654/dist/gcc-compatible/Hacl_SHA2_Vec128.h#L38