Update OCaml builds in Makefile

R1kM commented 1 month ago

Following @mtzguido 's suggestion, add -thread to the OCAMLOPT/SHARED aliases in Makefiles. This should also remove a recent warning during builds.

github-actions[bot] commented 1 month ago

[CI] Important! The code in dist/gcc-compatible, dist/msvc-compatible, and dist/wasm is tested on cryspen/hacl-packages. dist is not automatically re-generated, be sure to do it manually. (A fresh snapshot can also be downloaded from CI by going to the "artifacts" section of your run.) Then check the following tests before merging this PR. Always check the latest run, it corresponds to the most recent version of this branch. All jobs are expected to be successful. In some cases manual intervention is needed. Please ping the hacl-packages maintainers.

Build, Test, Benchmark: Build on Linux (x86, x64), Windows (x86, x64), MacOS (x64, arm64), s390x, Android (arm64) and test on Linux (x86, x64), Windows (x86, x64), MacOS (x64).
Performance Regression Tests: Navigate to the terminal output in “Run benchmarks”. The comparison with the main branch will be at the bottom. The run fails if the performance regresses too much.
OCaml bindings: Build & Tests
JS bindings: Build & Tests
Rust bindings: Build & Tests

R1kM commented 1 month ago

This is blocked on other fixes to HACL* proofs (#945, #947). Closing, to integrate it in existing PRs.

hacl-star / hacl-star

Update OCaml builds in Makefile #948