Closed wuwentao closed 1 month ago
hacs-bot[bot]
commented
2 months ago Make sure you have read the issue guidelines and that you filled out the entire template.
If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a :+1: reaction to the issue description. Thanks! :+1:
tjorim
commented
2 months ago We never 'replace' a repo. Open an issue or PR to remove the old one. Afterwards open a PR to add your fork. Just make sure you read all the requirements.
wuwentao
commented
2 months ago got it, thank you very much for your help and answer. I will try to remove old one, then add the fork again. edit and add remove PR info: https://github.com/hacs/default/pull/2504
Repository
georgezhao2010/midea_ac_lan
Checklist
Why should this be removed?
Description:
if we install midea_ac_lan from HACS, it can't work any more , just return an unkown error. as the hacs.json input an error file name mieda_ac_lan.zip, the right name should be midea_ac_lan.zip
old repo URL that can't work : https://github.com/georgezhao2010/midea_ac_lan the hacs domain: midea_ac_lan the hacs name: Midea AC Lan
Plan:
most github user report issue and PR about it, got no any reponse for a long time. now I'm decide to fork and continue maintainer with it in future
https://github.com/wuwentao/midea_ac_lan (it should a works verion with the error fix and some new PR merged.)
and I' also send send email to the origin maintainer, got no repsone. report a github issue in the origin repo: https://github.com/georgezhao2010/midea_ac_lan/issues/517
Question:
I'm not sure with how to do it now, so I just file a new PR to check and confirm with it ,then i will file PR to follow the rule with our suggestion.
Option 1. file PR to replace my forked repo with old repo? and continue maintain it in future ? Option 2. or remove old midea_ac_lan or temp black list? and add a new name with it and file to hacs default?
Thanks Wentao
Link to issue
https://github.com/georgezhao2010/midea_ac_lan/issues/517