hacs / integration

HACS gives you a powerful UI to handle downloads of all your custom needs.
https://hacs.xyz
MIT License
4.87k stars 1.22k forks source link

Validation fails when a brand gets moved from custom to core #3812

Closed andrew-codechimp closed 1 week ago

andrew-codechimp commented 1 week ago

Describe the issue

I have just had my custom integration domain sort of sherlocked by core, this means the validation for brands fails as the icons have moved.

frenck told me to take it up here as the icon will still work for hacs, it's just the validation that's the issue. I think the validation needs to be changed to support core and custom locations so a custom integration can override a core one.

https://github.com/home-assistant/brands/pull/5581

Link to action run

https://github.com/andrew-codechimp/HA-Mealie/actions/runs/9647678240/job/26607055465

Link to action configuration

https://github.com/andrew-codechimp/HA-Mealie/blob/main/.github/workflows/validate.yml

Checklist

hacs-bot[bot] commented 1 week ago

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a :+1: reaction to the issue description. Thanks! :+1:

ludeeus commented 1 week ago

This is behaving as designed. You can turn of the check for “brands” if you are reusing a core domain.