hacs / integration

HACS gives you a powerful UI to handle downloads of all your custom needs.
https://hacs.xyz
MIT License
4.88k stars 1.23k forks source link

HACS download fails #3842

Closed enoch85 closed 5 days ago

enoch85 commented 5 days ago

System Health details

TBA

Checklist

Describe the issue

I don't know if this is the correct repo to post the issue, but I'm having issues downloading a certain HACS integration since the download seems to get malformed.

I'm not home right now, so I can't add all the info needed here, but will update later tonight.

Reproduction steps

  1. Try to download hass-peaqhvac within HACS
  2. Notice that it fails ...

The real link should be https://github.com/elden1337/hass-peaqhvac/releases/download/3.0.1/peaqhvac.zip but HACS tried to download https://github.com/elden1337/hass-peaqhvac/releases/download/tags/3.0.1/peaqhvaq.zip (notice the tags addition).

Debug logs

This error originated from a custom integration.

Logger: custom_components.hacs
Source: custom_components/hacs/repositories/base.py:986
integration: HACS (documentation, issues)
First occurred: 08:18:39 (1 occurrences)
Last logged: 08:18:39

<Integration elden1337/hass-peaqhvac> Failed to download https://github.com/elden1337/hass-peaqhvac/releases/download/tags/3.0.1/peaqhvaq.zip

Diagnostics dump

No response

hacs-bot[bot] commented 5 days ago

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a :+1: reaction to the issue description. Thanks! :+1:

ludeeus commented 5 days ago

Report this to the author. https://github.com/elden1337/hass-peaqhvac/blob/main/hacs.json#L5

enoch85 commented 5 days ago

Hmm, I'm not quite sure since the download fails due to missing /tags/ in the URL.

Do you mean that the author should change the code somehow to remove /tags/ in the URL? The line you posed are correct from my understanding, since the actual zip is named what's in the code.

ludeeus commented 5 days ago

No, that is not it, the author say the filename is peaqhvaq.zip but it should be peaqhvac.zip.

enoch85 commented 5 days ago

Thanks! I'll send a PR.