HACS do not respect the use of the primary_font-family variable

nagtegaal commented 2 months ago

Web browser

Safari

Web browser version

17.8

System Health details

Even this link is out of date. There is no System health card located at the location mentioned in the link above. I can not seem to find the info, the description above this field refers to.

Checklist

[X] I'm running the newest version of HACS https://github.com/hacs/integration/releases/latest
[X] I have filled out the issue template to the best of my ability.
[X] I have read https://hacs.xyz/docs/help/issues/
[X] This issue is related to the frontend of HACS.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This is a bug and not a feature request.
[X] This issue is not a duplicate issue of currently open or issues pending release.

Describe the issue

Change the primary font CSS variable in a theme of choice, to something other than the default "Roboto" and it isn't working/inherited in HACS 2. The primary_font_variable isn't used in the HACS code, which leads to unstyled content and an ever more inconsistent UI (amaturistic).

It would be nice if also HACS could respect the CSS variables. To me, this feels more like a bug than a feature request. Although, it's best for the maintainer to categorise this.

Reproduction steps

Open your own custom theme
Change primary-font-family to the name of the font you linked to at the "Add resources" dashboard-page in the Dasgboard-settings.
Clear caches and reload yaml/theme, etc
See how the custom font is used, but not inside HACS. ...

Screenshots

Javascript logs from your browser console

N/A

Diagnostics dump

N/A

hacs-bot[bot] commented 2 months ago

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a :+1: reaction to the issue description. Thanks! :+1:

nagtegaal commented 2 months ago

ludeeus commented 2 months ago

Do Home Assistant pass this to iframes?

ludeeus commented 2 months ago

I checked, no. So this would be a feature request for HA, once its done there it will just start working.

nagtegaal commented 2 months ago

Thanks for your time/information, I made a bug report/feature request to fix/add this to basic HA...

hacs / integration