search

hacsoc / the_jolly_advisor

Get Jolly!
http://advise.case.edu/
MIT License
15 stars 21 forks source link

Denote which tab is clicked in Nav Bar #174

Open Aghassi opened 8 years ago

Aghassi commented 8 years ago

Right now, it is a tad confusing which tab a user is in when browsing the site. The tab should remained clicked or "indented" so I know which tab I am in. Also, I find it weird that the "Get Jolly" title and the "Explorer" tab both lead to the same page. Pedantic, but figured I should say something.

ajm188 commented 8 years ago

Do you want to work on this? If so, I'll leave you to it. If not, it will get done ... eventually.

Aghassi commented 8 years ago

@ajm188 I should bite my tongue in the future. I'm not a ruby dev, and looking through the source I have no idea what manages the actual nav-bar. I see the HAML file where it is generated, but beyond that I'm sort of lost. I'll probably play around with it in my free time, but the time it will get done by is probably on the same time scale as eventually

ajm188 commented 8 years ago

Actually, I'm glad you didn't. We need people actually using this and submitting issues. The problem is I don't have much time to devote to this, and I don't think many others are actively working on it.

As for the actual changes this requires, you can probably work exclusively in the haml files. The only "ruby" thing (it's actually a rails thing), you might need is link_to, which creates links pretty much as you would expect. Docs here.

StephHippo commented 8 years ago

This Stack Overflow question should answer what you want to aim for our project. I'm happy to talk you through it if you just want to ping me after work some time. http://stackoverflow.com/questions/829727/highlight-tab-in-menu

Aghassi commented 8 years ago

@StephHippo I'd love to, but this weekend or next week would be better for me. I have a lot of work on my plate at the moment.

StephHippo commented 8 years ago

Any time. That was meant to be more of an open-ended invitation. :)