search

hacsoc / the_jolly_advisor

Get Jolly!
http://advise.case.edu/
MIT License
15 stars 21 forks source link

Different periods for recitations? #224

Open civiliangame opened 8 years ago

civiliangame commented 8 years ago

image

This shows the recitations to be way longer than what is advertised on the CWRU schedules.

image

As you can see here, the Jolly Advisor says that recitations are 1:15 minutes each while the CWRU homepage claims that they are 50 minutes each. Thanks! Phillip

JKobyP commented 8 years ago

I've successfully reproduced the bug. @ajm188 sounds like a SIS syncing problem?

ajm188 commented 8 years ago

@thehunter9709 thanks for reporting!

@JKobyP, indeed. The SIS syncing is currently additive only. So, if a course changes it's time length, we wouldn't pick that up automatically, since in a way we would "delete" the old time and add the new time.

I am also wondering: is it possible this is data from the wrong semester/year?

JKobyP commented 8 years ago

@ajm188 If your question is toward whether this is human error, I'll tell you I paid particular attention to that, because that was my first assumption when the bug was posted.

We can close this as duplicate then, I suppose. But we need to figure out how to fix our additivity issue. It's not a feature that's working for us.

StephHippo commented 8 years ago

Weighing in, but this was a design issue that was discussed at length in the beginning. We ended up going with additive (which everyone agreed wasn't a fantastic long-term solution) because of the difficulties in uniquely identifying recitations when they changed. That being said, we know a little more about SIS data now, so it's probably overdue to revisit it.

Looks like the model could be extended to include a recitation ID. Does anyone know how often those change when the time of the recitation changes?