search

hadabot / hadabot_main

Content used in collaboration with various Hadabot blog posts to get guide you through learning ROS2.
https://blog.hadabot.com
GNU General Public License v3.0
37 stars 19 forks source link

WWW - Hiding network password during firmware file bundle upload #21

Closed Luke-Ferderer closed 2 years ago

Luke-Ferderer commented 2 years ago

On the page Setup ESP32 Upload Hadabot File Bundle I feel that the network password should be hidden as users enter it. Improves privacy if being used in a public space.

jackpien commented 2 years ago

Good consideration. I've pondered over hiding it, but I think if you are punching in a WiFi password in a public space, likely everyone is on that WiFi (and knows the password anyway).

I show it in clear text since the problems from a typo outweigh the privacy considerations?

Is this fair? I'll keep the issue open until you get to ponder my explanation. Thx.

Luke-Ferderer commented 2 years ago

I think a good option might be what many websites have where there is a button to toggle the password between plain text and dots.

jackpien commented 2 years ago

When form is changed to "password" type (which hides the password), the browsers will always request to "save the password" which is not relevant in this application. SSID passwords are generally pretty low risk so think it's ok. Even if in a public space, you are going to assign the pwd for the public SSID WiFi so everyone will know it anyway. Will not change for now unless a more compelling reason comes up.