search

hadalin / chrome-hidefedora

Chrome extension that removes troll youtube commenters (development discontinued)
http://hidefedora.hadalin.me
MIT License
60 stars 9 forks source link

Banned words don't always work #42

Closed jeffreymcclain closed 9 years ago

jeffreymcclain commented 9 years ago

I've noticed that if a banned word, such as "r/", is is present near the closing of a comment, which can only be revealed by clicking "show more", than the comment itself is not blocked. This is an issue, since many fedora wearers avoid using keywords such as "le Reddit" and moderator of "r/..." until the closing of their long-winded comment. This leads to some of their comments still being shown.

It's also possible I am simply not using the banned words list correctly. I am assuming that if I add "r/" to the list, all comments including words such as "/r/feminism" or "/r/racism" or so on will be blocked since they include "r/" somewhere in the comment.

Fogest commented 9 years ago

I'm not the developer however I believe the problem is that the content in the read more section is not loaded which means when checking for banned words it doesn't have the full comment to look at On Dec 31, 2014 6:00 PM, "random6969" notifications@github.com wrote:

I've noticed that if a banned word, such as "r/", is is present near the closing of a comment, which can only be revealed by clicking "show more", than the comment itself is not blocked. This is an issue, since many fedora wearers avoid using keywords such as "le Reddit" and moderator of "r/..." until the closing of their long-winded comment. This leads to some of their comments still being shown.

It's also possible I am simply not using the banned words list correctly. I am assuming that if I add "r/" to the list, all comments including words such as "/r/feminism" or "/r/racism" or so on will be blocked since they include "r/" somewhere in the comment.

— Reply to this email directly or view it on GitHub https://github.com/hadalin/chrome-hidefedora/issues/42.

jeffreymcclain commented 9 years ago

Is there a way to force youtube to load the full comments automatically so your extension can check for the banned words in every part of every comment to ensure maximum fedora hiding?

Fogest commented 9 years ago

I'm not the dev so I will wait for their comment but I'm sure it is possible I just don't know how it would affect load times on the page. On Dec 31, 2014 6:42 PM, "random6969" notifications@github.com wrote:

Is there a way to force youtube to load the full comments so your extension can check for the banned words in every part of every comment to ensure maximum fedora hiding?

— Reply to this email directly or view it on GitHub https://github.com/hadalin/chrome-hidefedora/issues/42#issuecomment-68475278 .

jeffreymcclain commented 9 years ago

Ok, thanks for helping me understanding the issue. Also, I have a relatively fast internet connection, so I wouldn't mind having to wait a little longer for the comments to automatically load in full to ensure that this extension can do it's work effectively. Anyways, I guess i'll wait for the dev's comment to see what he/she has to say.

Fogest commented 9 years ago

It is more a matter of computing power than connection speed. And you gotta think of the other users.

Justin V

On Wed, Dec 31, 2014 at 6:49 PM, random6969 notifications@github.com wrote:

Ok, thanks for helping me understanding the issue. Also, I have a relatively fast internet connection, so I wouldn't mind having to wait a little longer for the comments to automatically load in full to ensure that this extension can do it's work effectively. Anyways, I guess i'll wait for the dev's comment to see what he/she has to say.

— Reply to this email directly or view it on GitHub https://github.com/hadalin/chrome-hidefedora/issues/42#issuecomment-68475470 .

jeffreymcclain commented 9 years ago

Lol, I didn't mean for you to add the "auto-expand comments" to your own extension, cuz I know that would take time and computing power. I was just asking if it was possible with another extension / youtube setting that i might just not be aware of. This in turn would help the "banned words" feature of your extension work better on my own computer. Anyways, I was planning to apply this individually, I wasn't asking you to incorporate it as a feature.

hadalin commented 9 years ago

I think the problem is with escaping html characters. Will take a look when I get home.

On 1. jan. 2015, at 00.58, random6969 notifications@github.com wrote:

Lol, I didn't mean for you to add the "auto-expand comments" to your own extension, cuz I know that would take time and computing power. I was just asking if it was possible with another extension / youtube setting that i might just not be aware of. This in turn would help the "banned words" feature of your extension work better on my own computer. Anyways, I was planning to apply this individually, I wasn't asking you to incorporate it as a feature.

— Reply to this email directly or view it on GitHub.

hadalin commented 9 years ago

This should work now.

hadalin commented 9 years ago

@random6969 I must warn you though that some sites like www.example.com/arrr/index.php will also get removed.