Fixed injection on MonoBehaviours not working if the registration was made using base class identifier

hadashiA / VContainer

The extra fast, minimum code size, GC-free DI (Dependency Injection) library running on Unity Game Engine.

https://vcontainer.hadashikick.jp

MIT License

1.89k stars 165 forks source link

Fixed injection on MonoBehaviours not working if the registration was made using base class identifier #559

Closed pnarimani closed 11 months ago

pnarimani commented 11 months ago

Unit tests RegisterComponentInHierarchyUsingBaseClass and RegisterComponentInNewPrefabUsingBaseClass highlight the issue. Fixed FindComponentProvider and PrefabComponentProvider so they actually inject the type that is being found/instantiated instead of the base type.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vcontainer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2023 3:34am

hadashiA commented 11 months ago

Thanks! 👍