Inject before awake when instantiating

hadashiA / VContainer

The extra fast, minimum code size, GC-free DI (Dependency Injection) library running on Unity Game Engine.

https://vcontainer.hadashikick.jp

MIT License

1.89k stars 165 forks source link

Closed AlonTalmi closed 8 months ago

AlonTalmi commented 10 months ago

Solves #540

The object is instantiated disabled and only enabled after it was injected, that way awake is only called after injection.

Added to the existing Unit Test an assert proving the bug

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vcontainer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 2:49pm

hadashiA commented 9 months ago

@AlonTalmi 👍 Thanks for the fixing. I think it is a good improvement. I was going to merge, can I get the conflicts resolved?

hadashiA commented 8 months ago

I was able to follow your commit and resolve the conflict. I've merged it here. Thanks.