search

hadashiA / VContainer

The extra fast, minimum code size, GC-free DI (Dependency Injection) library running on Unity Game Engine.
https://vcontainer.hadashikick.jp
MIT License
1.81k stars 157 forks source link

Fix Diagnostic window. #655

Closed DenisPimenov closed 3 months ago

DenisPimenov commented 3 months ago

Hi @hadashiA ! I have the problem described here https://github.com/hadashiA/VContainer/issues/621. I've been looking at the logic for collecting diagnostics and was going to suggest the simple solution, to check the unique scopes with GameObject instanceId. There is a small problem from using Lookup when building a window. For this I had to add an instanceId to the name of the scope to output to the window.

Also wanted to suggest to add cleaning the scopes from the diagnostics after Dispose/Destroy.

If you have any other suggestions I can fix this solution.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vcontainer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:51am
hadashiA commented 3 months ago

Thank you!

However, there was a slight point of concern. I want the DiagnosticsContext to be able to collect information in a Unity-independent layer. So I don't want to rely too much on the concept of instanceId. After all, I don't think I need to increase the argument for GetCollector, since the string will still be the key.

I will probably rework that after your commit. Thanks a lot.