Added test and fix for when a game object throws during instantiation

hadashiA / VContainer

The extra fast, minimum code size, GC-free DI (Dependency Injection) library running on Unity Game Engine.

https://vcontainer.hadashikick.jp

MIT License

1.81k stars 157 forks source link

Added test and fix for when a game object throws during instantiation #660

Closed NordlightPer closed 2 months ago

NordlightPer commented 2 months ago

In our game we sometimes have problems during the init of a game mode. When this happens, we have a transition game object that is disabled and occasionally that change gets committed. Similar try finally guards other code paths but not the one we were using. This fixes our case but maybe all paths should have this construct?

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vcontainer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 23, 2024 9:52am

hadashiA commented 2 months ago

This change is probably desirable. Thanks a lot.