List pool usage extended to other valiable places

hadashiA / VContainer

The extra fast, minimum code size, GC-free DI (Dependency Injection) library running on Unity Game Engine.

https://vcontainer.hadashikick.jp

MIT License

1.92k stars 167 forks source link

List pool usage extended to other valiable places #683

Closed Raegan03 closed 3 months ago

Raegan03 commented 3 months ago

After the fix for the ListPool, I've decided to look a bit into how and when it's used. I've managed to find some additional use cases as well as refactor a bit the ListPool class and include some UnitTests for it.

I'm not sure what the approach to the thread safety is, but the ThreadStaticattribute was not handled well there and I think that lock is a better idea.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vcontainer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 19, 2024 4:43pm

hadashiA commented 3 months ago

LGTM. Thanks 👍