search

haddocking / haddock3

Official repo of the modular BioExcel version of HADDOCK
https://www.bonvinlab.org/haddock3
Apache License 2.0
84 stars 28 forks source link

Add `codacy/codacy-coverage-reporter-action` action to `tests.yml` #875

Closed rvhonorato closed 2 months ago

rvhonorato commented 2 months ago

This add integration with Codacy - https://app.codacy.com/gh/haddocking/haddock3/, in line with the other tools from the group

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 56ca74a4a0db2faed300f323b22ddaf0426ba6e0[^1] :white_check_mark: ∅
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (56ca74a4a0db2faed300f323b22ddaf0426ba6e0) | Report Missing | Report Missing | Report Missing | | | Head commit (98f3fc7bf39247425a6ce70ab8d4cc58654c8bc4) | 12214 | 9827 | 80.46% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#875) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

mgiulini commented 2 months ago

I think these checks are way too strict..I would add this action later on in the project when the production version is stable/published and the development slows down

rvhonorato commented 2 months ago

There are no checks, it just display things over there and this is needed for FAIRness

*the checks are configured in the repository settings - none are configured right now, this PR just just sends the coverage report to codacy. If you don't want to send the coverage reports, the repository is still linked anyway to check for code quality https://app.codacy.com/gh/haddocking/haddock3/

mgiulini commented 2 months ago

There are no checks, it just display things over there and this is needed for FAIRness

*the checks are configured in the repository settings - none are configured right now, this PR just just sends the coverage report to codacy. If you don't want to send the coverage reports, the repository is still linked anyway to check for code quality https://app.codacy.com/gh/haddocking/haddock3/

ok, then can't it be hidden from the actions report? I really hate seeing failed actions (see https://github.com/haddocking/haddock3/pull/862) for reasons like this https://app.codacy.com/gh/haddocking/haddock3/pull-requests/862/issues#issue-da28e38929afc9695f2cd4cb38d5e415

rvhonorato commented 2 months ago

That's a configuration in codacy, has nothing to do with this PR