haddocking / haddock3

Official repo of the modular BioExcel version of HADDOCK
https://www.bonvinlab.org/haddock3
Apache License 2.0
101 stars 33 forks source link

Updated CNS installation instructions #895

Closed amjjbonvin closed 4 months ago

amjjbonvin commented 4 months ago

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:


"This PR improves the readablity of the CNS installation instructions and also changes the folder structure of the patched CNS files" @rvhonorato

rvhonorato commented 4 months ago

ping @VGPReys @AnnaKravchenko

amjjbonvin commented 4 months ago

why is there a \ sign before the cp command ?

Basic Linux, with the \ is uses the basic command, without any option possibly defined in an alias.

amjjbonvin commented 4 months ago

Also the [bis] statement is quite confusing

Again, Linux shell selection syntax: It will select any file or directory starting with a: b, i or s

amjjbonvin commented 4 months ago

Does work on my Mac under tcsh, but not under bash…

And there are some character issues for ‘ and #

Should we add sed -i '' 's@_CNSsolvelocation@'"$PWD"'@‘ cns_solve_env as an alternative to installing gnu-sed on Mac? But also idk if it works in general or only ‘on my machine’

AnnaKravchenko commented 4 months ago

Yeah, then let’s just keep it as is. After all it’s trivial to make changes manually.

Does work on my Mac under tcsh, but not under bash… And there are some character issues for ‘ and # Should we add sed -i '' 's@_CNSsolvelocation@'"$PWD"'@‘ cns_solve_env as an alternative to installing gnu-sed on Mac? But also idk if it works in general or only ‘on my machine’