search

haddocking / pdb-tools

A dependency-free cross-platform swiss army knife for PDB files.
https://haddocking.github.io/pdb-tools/
Apache License 2.0
369 stars 112 forks source link

Increase footer size in the web page #132

Closed rvhonorato closed 2 years ago

rvhonorato commented 2 years ago

This tweak to the footer dimension, from the default 270px to 280px should fix #128

joaomcteixeira commented 2 years ago

Thanks for this. Although I could not reproduce the issue locally, I did test the footer expansion, and it seems harmless. I don't know if makes sense to expand it further because the limit is 340px, but we need to let some px for the spacing between the lateral menu and the main page. Let's try with 280 then :wink:

I will wait some days before merging for others to comment if they wish.

rvhonorato commented 2 years ago

Thanks for this. Although I could not reproduce the issue locally, I did test the footer expansion, and it seems harmless.

https://www.rvhonorato.me/pdb-tools/

I don't know if makes sense to expand it further because the limit is 340px, but we need to let some px for the spacing between the lateral menu and the main page. Let's try with 280 then 😉

Thanks for your comment, but could you please clarify what you mean? Is the footer increase a good fix or not?

joaomcteixeira commented 2 years ago

Sorry for the late reply. Thanks for hosting the webpage. It seems clean and working, at least with your nickname :wink: @JoaoRodrigues do you agree to merge this? I agree. We should use the [SKIP] flag here.