search

haddocking / pdb-tools

A dependency-free cross-platform swiss army knife for PDB files.
https://haddocking.github.io/pdb-tools/
Apache License 2.0
378 stars 113 forks source link

Considers isalhum in pdb_selchain #40

Closed joaomcteixeira closed 4 years ago

joaomcteixeira commented 4 years ago

Considers chain options to be valid when str.isalnum() is True.

Solves #39

codecov[bot] commented 4 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          44       44           
  Lines        3525     3525           
  Branches      742      742           
=======================================
  Hits         2893     2893           
  Misses        446      446           
  Partials      186      186
Impacted Files Coverage Δ
pdbtools/pdb_selchain.py 84.61% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb1baf7...ba556bf. Read the comment docs.

mtrellet commented 4 years ago

Works fine on my side! Thanks ;)

joaomcteixeira commented 4 years ago

Added tests for selecting capital chain identifiers, lowercase identifiers and digit identifiers.

@JoaoRodrigues review and merge if appropriate.

JoaoRodrigues commented 4 years ago

Seems good! Thanks for the fix and the tests!