search

haddocking / pdb-tools

A dependency-free cross-platform swiss army knife for PDB files.
https://haddocking.github.io/pdb-tools/
Apache License 2.0
378 stars 113 forks source link

pdb_validate outputs to sys.stdout #44

Closed joaomcteixeira closed 4 years ago

joaomcteixeira commented 4 years ago

Implements changes proposed by @brianjimenez in #43

Because this is a design related implementation I would like to hear from @JoaoRodrigues, please decide whether or not you agree with the proposal.

In case you do, here is the PR already.

I have not run the tests locally. I will wait for the CI to do it for me :smile:

joaomcteixeira commented 4 years ago

Updated tests,

----------------------------------------------------------------------
Ran 279 tests in 0.088s

OK
codecov[bot] commented 4 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          44       44           
  Lines        3525     3525           
  Branches      742      742           
=======================================
  Hits         2893     2893           
  Misses        446      446           
  Partials      186      186
Impacted Files Coverage Δ
pdbtools/pdb_validate.py 88.31% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b39fb96...4c274ae. Read the comment docs.