haddocking / pdb-tools

A dependency-free cross-platform swiss army knife for PDB files.
https://haddocking.github.io/pdb-tools/
Apache License 2.0
372 stars 113 forks source link

[FEATURE] Added new tool to assign unique names to HETATM atoms + tests #75

Closed JoaoRodrigues closed 3 years ago

JoaoRodrigues commented 3 years ago

Addresses #71

Note the [FEATURE] tag on the PR name. Should be pushed to the main branch with this name to trigger a minor version change (so, 2.1.0 instead of 2.0.8) because of the new tool!

codecov[bot] commented 3 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.30%. The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   81.78%   82.09%   +0.30%     
==========================================
  Files          44       45       +1     
  Lines        3520     3574      +54     
  Branches      737      748      +11     
==========================================
+ Hits         2879     2934      +55     
+ Misses        453      451       -2     
- Partials      188      189       +1     
Impacted Files Coverage Δ
pdbtools/pdb_uniqname.py 96.49% <96.49%> (ø)
pdbtools/pdb_delresname.py 81.81% <0.00%> (+1.04%) :arrow_up:
pdbtools/pdb_selresname.py 81.81% <0.00%> (+1.04%) :arrow_up:
pdbtools/pdb_selatom.py 84.41% <0.00%> (+1.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37008a8...03f8c04. Read the comment docs.

JoaoRodrigues commented 3 years ago

Back to you @joaomcteixeira !

PS. If you merge, copy the [FEATURE] tag to the commit message (before the merge commit)

joaomcteixeira commented 3 years ago

Dear @JoaoRodrigues ,

You have correctly addressed all requests demanded by reviewer 1. We happy to announce your PR will be accepted for merge, after reviewer 2 provides positive feedback or you yourself decide to merge because you are the owner :stuck_out_tongue_closed_eyes:

Fine to merge on my end. :wink:

JoaoRodrigues commented 3 years ago

Let's see if we get 2.1.0... :)

JoaoRodrigues commented 3 years ago

And we do!

joaomcteixeira commented 3 years ago

Git actions working :D