hadess
commented
6 years ago Stop iio-sensor-proxy, and try reading the values directly from the sysfs files. The values certainly seem weird.
Closed aik closed 4 years ago
hadess
commented
6 years ago Stop iio-sensor-proxy, and try reading the values directly from the sysfs files. The values certainly seem weird.
aik
commented
6 years ago Uff, took a while to check this :-/
[root@aikyoga2 iio:device0]# pwd /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-4/i2c-ITE8350:00/0018:048D:8350.0008/HID-SENSOR-200073.4.auto/iio:device0 [root@aikyoga2 iio:device0]# ls .. driver driver_override iio:device0 modalias power subsystem trigger0 uevent [root@aikyoga2 iio:device0]# while [ true ] ; do for i in inaccel?_raw ; do echo $i: $(cat $i) ; done ; sleep 2 ; done in_accel_x_raw: 11 in_accel_y_raw: 64654 in_accel_z_raw: 65064 in_accel_x_raw: 11 in_accel_y_raw: 64650 in_accel_z_raw: 65068 in_accel_x_raw: 11 in_accel_y_raw: 64654 in_accel_z_raw: 65064 in_accel_x_raw: 11 in_accel_y_raw: 64654 in_accel_z_raw: 65064 in_accel_x_raw: 11 in_accel_y_raw: 64673 in_accel_z_raw: 65036
Here I turned the laptop 90deg clockcounterwise: in_accel_x_raw: 64568 in_accel_y_raw: 65310 in_accel_z_raw: 65529 in_accel_x_raw: 64579 in_accel_y_raw: 65314 in_accel_z_raw: 65494 in_accel_x_raw: 64579 in_accel_y_raw: 65318 in_accel_z_raw: 65497
And back: in_accel_x_raw: 11 in_accel_y_raw: 64658 in_accel_z_raw: 65142 in_accel_x_raw: 11 in_accel_y_raw: 64654 in_accel_z_raw: 65072 in_accel_x_raw: 11 in_accel_y_raw: 64654 in_accel_z_raw: 65056
Raw readings seems to be fine. I looked further: [root@aikyoga2 iio:device0]# pwd /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-4/i2c-ITE8350:00/0018:048D:8350.0008/HID-SENSOR-200073.4.auto/iio:device0 [root@aikyoga2 iio:device0]# find -iname "in_accel*" ./in_accel_y_raw ./scan_elements/in_accel_y_en ./scan_elements/in_accel_z_index ./scan_elements/in_accel_x_en ./scan_elements/in_accel_z_type ./scan_elements/in_accel_x_index ./scan_elements/in_accel_z_en ./scan_elements/in_accel_y_type ./scan_elements/in_accel_x_type ./scan_elements/in_accel_y_index ./in_accel_z_raw ./in_accel_scale ./in_accel_sampling_frequency ./in_accel_offset ./in_accel_x_raw ./in_accel_hysteresis
The iio-sensor-proxy has 2 orientatio drivers - polling and buffering - one reads inaccel?_raw files, the other reads some "channels" called inaccel? and these are not files (what are they?).
The existing code picks the buffering driver and that thing works wrong.
But the polling driver actually works better - at very least it does not keep rotating the screen in a loop without any actual movement (which is a progress), however it gets the actual orientation stil wrong, like always is mistaken by 90deg.
aik
commented
6 years ago Recorded some raw readings in process_scan_1(): https://github.com/aik/iio-sensor-proxy/commit/be6ee47932e2455ef2cafef02ea754a20b8521a7
(process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -15952, -28810, 20774 (scale 0.009807) 8f76c1b0 51268f76 5126 (process:22741): WARNING : Accel sent by driver (quirk applied): -15952, -28810, 20774 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from bottom-up to normal (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 0 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 0 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807) (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, -22381 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 0 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, -22381, 20774 (scale 0.009807) a8930000 5126a893 5126 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, -22381, 20774 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -32146, -6309, -14224 (scale 0.009807) e75b826e c870e75b ff00c870 (process:22741): WARNING : Accel sent by driver (quirk applied): -32146, -6309, -14224 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from normal to right-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 9039, -6309, -6550 (scale 0.009807) e75b234f e66ae75b ff00e66a (process:22741): WARNING : Accel sent by driver (quirk applied): 9039, -6309, -6550 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from right-up to left-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -17680, -13982, 32146 (scale 0.009807) c962baf0 7d92c962 ff007d92 (process:22741): WARNING : Accel sent by driver (quirk applied): -17680, -13982, 32146 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -15831, 27082, -15952 (scale 0.009807) 69cac229 c1b069ca c1b0 (process:22741): WARNING : Accel sent by driver (quirk applied): -15831, 27082, -15952 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from left-up to bottom-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 12858, 13100, 242 (scale 0.009807) 332c323a f2332c 650000f2 (process:22741): WARNING : Accel sent by driver (quirk applied): 12858, 13100, 242 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from bottom-up to left-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -28447, -27203, -3214 (scale 0.009807) 95bd90e1 f37295bd ff00f372 (process:22741): WARNING : Accel sent by driver (quirk applied): -28447, -27203, -3214 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from left-up to right-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 15, -878, -480 (scale 0.009807) fc92000f fe20fc92 fe20 (process:22741): WARNING : Accel sent by driver (quirk applied): 15, -878, -480 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from right-up to normal (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 0 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 0 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807) (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 28690, 0, 6429 (scale 0.009807) 7012 191d0000 ff00191d (process:22741): WARNING : Accel sent by driver (quirk applied): 28690, 0, 6429 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from normal to left-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 1487, 30417, -19167 (scale 0.009807) 76d105cf b52176d1 ff00b521 (process:22741): WARNING : Accel sent by driver (quirk applied): 1487, 30417, -19167 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from left-up to bottom-up (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': -14465, -19167, -22381 (scale 0.009807) b521c77f a893b521 ff00a893 (process:22741): WARNING : Accel sent by driver (quirk applied): -14465, -19167, -22381 (scale: 0.009807) (process:22741): WARNING : Emitted orientation changed: from bottom-up to normal (process:22741): WARNING : BBBB Accel read from IIO on 'iio:device0': 0, 0, 0 (scale 0.009807) 0 0 ff000000 (process:22741): WARNING : Accel sent by driver (quirk applied): 0, 0, 0 (scale: 0.009807)
This numbers came when I just moved a laptop on a desk, no turning, just moving left/right by 1cm. The numbers look dodgy though.
hadess
commented
6 years ago Either the driver or the device seems to send garbage data. This is assuming there isn't a bug in iio-sensor-proxy for reading the update events from the buffered accelerometer. You should send a mail to the linux-iio mailing-list about it.
As for the 90 degrees rotation, see https://github.com/hadess/iio-sensor-proxy/#accelerometer-orientation
aik
commented
6 years ago I have a suspicion that the sensor might be broke actually as the screen does not even try to change screen orientation when I hold laptop in tablet mode (i.e. folded) in front of me and then turn it 90deg clockwise but it does when I turn 90deg clockcounterwise, is there a way to tell if it is not broken?
hadess
commented
6 years ago Look at the driver first.
aik
commented
5 years ago So. I got bored and looked there again :)This time it is fedora29 v4.20.14. The problem is there with the stock package. Then I tried git version of iio-sensor-proxy, same issue. Then I comment out &iio_buffer_accel to make &iio_poll_accel work - and things worked nicely. I looked in sysfs and inaccel?_raw seem to have correct values (same as in the first log below, give or take), all good. Recorded some debug from iio-sensor-proxy:
Accel read from IIO on 'accel_3d': -39, -937, -378 (scale 0.009807)
Accel sent by driver (quirk applied): -39, -937, -378 (scale: 0.009807)
Emitted orientation changed: from undefined to normal
No new data available on 'iio:device3'
Accel read from IIO on 'accel_3d': -39, -933, -371 (scale 0.009807)
Accel sent by driver (quirk applied): -39, -933, -371 (scale: 0.009807)
No new data available on 'iio:device3'
Accel read from IIO on 'accel_3d': -39, -933, -367 (scale 0.009807)
Accel sent by driver (quirk applied): -39, -933, -367 (scale: 0.009807)This is the good log, gnome works fine.
Then I recorded debug with the buffer driver enabled:
rocess_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0
process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4
process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8
Accel read from IIO on 'iio:device4': -15, -898, -375 (scale 0.009807)
Accel sent by driver (quirk applied): -15, -898, -375 (scale: 0.009807)
Emitted orientation changed: from undefined to normal
No new data available on 'iio:device3'
process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0
process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4
process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8
Accel read from IIO on 'iio:device4': 20774, 27203, 0 (scale 0.009807)
Accel sent by driver (quirk applied): 20774, 27203, 0 (scale: 0.009807)
Emitted orientation changed: from normal to left-up
No new data available on 'iio:device3'
process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0
process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4
process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8
Accel read from IIO on 'iio:device4': -31, -929, -398 (scale 0.009807)
Accel sent by driver (quirk applied): -31, -929, -398 (scale: 0.009807)
Emitted orientation changed: from left-up to normal
No new data available on 'iio:device3'
process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0
process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4
process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8
Accel read from IIO on 'iio:device4': -14345, -32024, 12738 (scale 0.009807)
Accel sent by driver (quirk applied): -14345, -32024, 12738 (scale: 0.009807)So it is good reading, bad reading, good reading, bad reading, and gnome rotates the screen non stop. I tend to blame the driver then but the IIO framework in the driver is quite complex and I failed to find quickly where there reads are handled in the kernel. Any pointers?
Here is dmesg | grep i2c:
[root@aikyoga iio:device4]# dmesg | egrep '(i2c|iio)'
[ 5.389867] i2c_hid i2c-ITE8350:00: i2c-ITE8350:00 supply vdd not found, using dummy regulator
[ 5.389893] i2c_hid i2c-ITE8350:00: Linked as a consumer to regulator.0
[ 5.389896] i2c_hid i2c-ITE8350:00: i2c-ITE8350:00 supply vddl not found, using dummy regulator
[ 5.502896] hid-generic 0018:048D:8350.0002: hidraw1: I2C HID v1.00 Device [ITE8350:00 048D:8350] on i2c-ITE8350:00
[ 5.528455] i2c_hid i2c-SYNA2B23:00: i2c-SYNA2B23:00 supply vdd not found, using dummy regulator
[ 5.528485] i2c_hid i2c-SYNA2B23:00: Linked as a consumer to regulator.0
[ 5.528489] i2c_hid i2c-SYNA2B23:00: i2c-SYNA2B23:00 supply vddl not found, using dummy regulator
[ 5.543440] input: SYNA2B23:00 06CB:2714 Mouse as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-6/i2c-SYNA2B23:00/0018:06CB:2714.0003/input/input13
[ 5.543690] hid-generic 0018:06CB:2714.0003: input,hidraw2: I2C HID v1.00 Mouse [SYNA2B23:00 06CB:2714] on i2c-SYNA2B23:00
[ 6.053237] input: Synaptics TM2714-002 as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-6/i2c-SYNA2B23:00/0018:06CB:2714.0003/input/input16
[ 6.053444] hid-rmi 0018:06CB:2714.0003: input,hidraw1: I2C HID v1.00 Mouse [SYNA2B23:00 06CB:2714] on i2c-SYNA2B23:00I've added more debug in git master, if you want to try again. The additional info might show whether other bits of data change.
As for the IIO subsystem, the code lives in drivers/iio/accel/.
aik
commented
5 years ago I found drivers/iio/accel but could not find the sysfs node for in_accel_x_raw, for example, it is hidded behind macros or comes from outside the kernel, what is it?
Anyway, here is a log with the new "bits used" (edited - the first cutnpaste was wrong):
** (process:9893): DEBUG: 08:50:10.382: process_scan_1: channel_index: 0, chan_name: in_intensity_both, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 32
** (process:9893): DEBUG: 08:50:10.383: Light read from IIO on 'iio:device3': 225000 (scale 0.010000) = 2249.999950
** (process:9893): DEBUG: 08:50:10.383: Light level sent by driver (quirk applied): 2249.999950 (unit: lux)
** (process:9893): DEBUG: 08:50:10.383: Emitted light changed: from 0.000000 to 2249.999950
** (process:9893): DEBUG: 08:50:10.383: process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:10.383: process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:10.383: process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:10.384: A Accel read from IIO on 'iio:device4': -42, -937, -363 (scale 0.009807)
** (process:9893): DEBUG: 08:50:10.384: Accel sent by driver (quirk applied): -42, -937, -363 (scale: 0.009807)
** (process:9893): DEBUG: 08:50:10.384: Emitted orientation changed: from undefined to normal
** (process:9893): DEBUG: 08:50:11.083: process_scan_1: channel_index: 0, chan_name: in_intensity_both, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 32
** (process:9893): DEBUG: 08:50:11.083: Light read from IIO on 'iio:device3': 611 (scale 0.010000) = 6.110000
** (process:9893): DEBUG: 08:50:11.084: Light level sent by driver (quirk applied): 6.110000 (unit: lux)
** (process:9893): DEBUG: 08:50:11.084: Emitted light changed: from 2249.999950 to 6.110000
** (process:9893): DEBUG: 08:50:11.084: process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.084: process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.085: process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.085: A Accel read from IIO on 'iio:device4': 3214, -4701, -31904 (scale 0.009807)
** (process:9893): DEBUG: 08:50:11.085: Accel sent by driver (quirk applied): 3214, -4701, -31904 (scale: 0.009807)
** (process:9893): DEBUG: 08:50:11.785: process_scan_1: channel_index: 0, chan_name: in_intensity_both, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 32
** (process:9893): DEBUG: 08:50:11.785: Light read from IIO on 'iio:device3': 604 (scale 0.010000) = 6.040000
** (process:9893): DEBUG: 08:50:11.785: Light level sent by driver (quirk applied): 6.040000 (unit: lux)
** (process:9893): DEBUG: 08:50:11.785: Emitted light changed: from 6.110000 to 6.040000
** (process:9893): DEBUG: 08:50:11.786: process_scan_1: channel_index: 0, chan_name: in_accel_x, channel_data_index: 0 location: 0 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.786: process_scan_1: channel_index: 1, chan_name: in_accel_y, channel_data_index: 1 location: 4 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.786: process_scan_1: channel_index: 2, chan_name: in_accel_z, channel_data_index: 2 location: 8 bytes: 4 is_signed: 1 be: 0 shift: 0 bits_used: 16
** (process:9893): DEBUG: 08:50:11.786: A Accel read from IIO on 'iio:device4': 15952, 23988, 22381 (scale 0.009807)
** (process:9893): DEBUG: 08:50:11.786: Accel sent by driver (quirk applied): 15952, 23988, 22381 (scale: 0.009807)
** (process:9893): DEBUG: 08:50:11.786: Emitted orientation changed: from normal to bottom-up
The problem isn't limited to the accelerometer:
Emitted light changed: from 0.000000 to 2249.999950
Emitted light changed: from 2249.999950 to 6.110000
Emitted light changed: from 6.110000 to 6.040000The first 2 changes are pretty bad.
Does this change make any difference on your system?
diff --git a/src/iio-buffer-utils.c b/src/iio-buffer-utils.c
index 4818d3e..9eb3fcd 100644
--- a/src/iio-buffer-utils.c
+++ b/src/iio-buffer-utils.c
@@ -68,7 +68,7 @@ iio_readu32 (struct iio_channel_info *info, const guint8 * data)
}
#define _IIO_GET(__data, __idx, __size, __shift) \
- (((guint##__size) (((const guint8 *) (__data))[__idx])) << (__shift))
+ (((gint##__size) (((const gint8 *) (__data))[__idx])) << (__shift))
#define _IIO_READ_INT32_BE(data) (_IIO_GET (data, 0, 32, 24) | \
_IIO_GET (data, 1, 32, 16) | \I'm wondering why you saw 0.0 0.0 0.0 readings using iio_generic_buffer and not using iio-sensor-proxy.
aik
commented
5 years ago No luck there. iiologbuffer.txt iiologpolling.txt
Here is the exact branch https://github.com/aik/iio-sensor-proxy/commit/41dcda9a431cf62504878e7c5
hadess
commented
5 years ago I've made some pretty big changes to the code to bring it back in line with the upstream code it was derived from 6 or 7 years ago (iio-sensor-proxy was based on a fork of a fork).
See the PR here for testing: https://github.com/hadess/iio-sensor-proxy/pull/269
The end goal here is that the iio_generic_buffer tool and iio-sensor-proxy give out the same readings. Anything else we can deal with afterwards.
hadess
commented
5 years ago Please test with version 2.6.
aik
commented
5 years ago Sorry for the delay but it is the exact same behaviour - keeps rotating, just seems slightly quicker than before. I am attaching the log. The laptop was on my laps and just a little movement make screen spinning like crazy.
hadess
commented
4 years ago
Tried this on Lenovo Yoga 710-11ISK - it keeps rotating the screen as the monitor-sensor keeps reporting changes. Fedora 27, iio-sensor-proxy has been compiled 15min ago, is that a broken sensor?