search

hadess / iio-sensor-proxy

IIO accelerometer sensor to input device proxy
196 stars 63 forks source link

WIP Proximity sensor support #291

Closed agx closed 4 years ago

agx commented 4 years ago

This adds proximity sensor support. The proximity of the vcnl4000 is single raw value. I'm marking as WIP since i'm not sure if this should be a different interface like compass or just go into the main interface?

agx commented 4 years ago

while working on #292 i noticed that drivers like the vcnl4000 that have both proximity and als currently have the issue that the same device can't have multiple IIO_SENSOR_PROXY_TYPE types. What would be the way forward here, making IIO_SENSOR_PROXY_TYPE a comma seperated list?

hadess commented 4 years ago

while working on #292 i noticed that drivers like the vcnl4000 that have both proximity and als currently have the issue that the same device can't have multiple IIO_SENSOR_PROXY_TYPE types. What would be the way forward here, making IIO_SENSOR_PROXY_TYPE a comma seperated list?

That sounds good, yes.

As for whether the interface should be separate, or simply another one like light, I think it depends on whether we consider it a potential security risk. Pointers to what Android, Windows or iOS consider it to be would be useful in making a decision.

agx commented 4 years ago

As for whether the interface should be separate, or simply another one like light, I think it depends on whether we consider it a potential security risk. Pointers to what Android, Windows or iOS consider it to be would be useful in making a decision.

android does not need extra permissions for the proximity sensor, there's no mention of permissions at https://developer.android.com/guide/topics/sensors/sensors_overview (see also https://stackoverflow.com/questions/20497087/manifest-xml-when-using-sensors), same seems to be true for iOS (https://developer.apple.com/documentation/uikit/uidevice/1620017-proximitymonitoringenabled?language=objc , https://developer.apple.com/documentation/uikit/uidevice) so i'll drop the extra dbus interface. I'll also split the support for different sensor types types into an extra series since these are independent things.

hadess commented 4 years ago

Moved to https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/merge_requests/291