search

hadi-guang / git-repo

Automatically exported from code.google.com/p/git-repo
Apache License 2.0
0 stars 0 forks source link

<remove-project> no longer working #159

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Affected Version: v1.12.9

What steps will reproduce the problem?
1. Using an android environment, add this line to a local manifest:   
<remove-project name="platform/packages/inputmethods/LatinIME" />
2. rm -rf packages/inputmethods/LatinIME
3. repo sync packages/inputmethods/LatinIME

What is the expected output? What do you see instead?
"error: project packages/inputmethods/LatinIME is not found"
And no code should be synced.

Instead there's no such error and the code is synced.

Since remove-project doesn't work I cannot replace an existing project in a 
manifest in a local manifest. 

Please provide any additional information below.

Using git bisect I have narrowed the problem down to this change:
commit 8d20116038ff78b22069dd4e993b5819775f03d1
Author: David James <davidjames@google.com>
Date:   Fri Oct 11 17:03:19 2013 -0700

    repo: Support multiple branches for the same project.

    It is often useful to be able to include the same project more than
    once, but with different branches and placed in different paths in the
    workspace. Add this feature.

    This CL adds the concept of an object directory. The object directory
    stores objects that can be shared amongst several working trees. For
    newly synced repositories, we set up the git repo now to share its
    objects with an object repo.

    Each worktree for a given repo shares objects, but has an independent
    set of references and branches. This ensures that repo only has to
    update the objects once; however the references for each worktree are
    updated separately. Storing the references separately is needed to
    ensure that commits to a branch on one worktree will not change the
    HEAD commits of the others.

    One nice side effect of sharing objects between different worktrees is
    that you can easily cherry-pick changes between the two worktrees
    without needing to fetch them.

    Bug:  Issue 141 
    Change-Id: I5e2f4e1a7abb56f9d3f310fa6fd0c17019330ecd

Original issue reported on code.google.com by jona...@gmail.com on 30 Jan 2014 at 3:57

GoogleCodeExporter commented 8 years ago 
Since repo is auto-updating to the latest version, this bug if quite severe and 
I would expect a lot of builds to start failing shortly.

Original comment by jona...@gmail.com on 30 Jan 2014 at 3:58

GoogleCodeExporter commented 8 years ago 
Yes, indeed. Our nightly build broke after updating its 'repo' code and then 
trying to run "repo sync". Please, fix ASAP!

Original comment by awolf...@gmail.com on 30 Jan 2014 at 4:34

GoogleCodeExporter commented 8 years ago 
Broke my builds as well. Please fix or let us know a work around

Original comment by rathor...@gmail.com on 30 Jan 2014 at 5:01

GoogleCodeExporter commented 8 years ago 
In <aosp_root>/.repo/repo checking out a new branch and reverting that commit 
works for me.

Original comment by Ladios.J...@gmail.com on 30 Jan 2014 at 5:05

GoogleCodeExporter commented 8 years ago 
Yup broke for us aswell, remove-project is indeed needed!

Thanks!

Original comment by sfera...@gmail.com on 30 Jan 2014 at 5:16

GoogleCodeExporter commented 8 years ago 
My build broken too. Bisected to same commit.
Is there any way to tell not to autoupdate or to use a specific version of repo?

Original comment by mfuz...@parkeon.com on 30 Jan 2014 at 5:17

GoogleCodeExporter commented 8 years ago 
Goto android/.repo/repo dir
git branch test
git checkout test
git revert 8d20116038ff78b22069dd4e993b5819775f03d1

It will revert the commit for now. But will need to update when an update is 
released

Original comment by rathor...@gmail.com on 30 Jan 2014 at 5:20

GoogleCodeExporter commented 8 years ago 
I'm working on a patch to fix this.

Original comment by davidjames@chromium.org on 30 Jan 2014 at 6:13

GoogleCodeExporter commented 8 years ago 
https://gerrit-review.googlesource.com/#/c/54129/ should fix

Original comment by davidjames@chromium.org on 30 Jan 2014 at 6:26

GoogleCodeExporter commented 8 years ago 
@David: The change doesn't seem to be publicly available. "The page you 
requested was not found, or you do not have permission to view this page."

Original comment by jona...@gmail.com on 30 Jan 2014 at 6:34

GoogleCodeExporter commented 8 years ago 
I just updated with a "repo sync" and seems to work for us now.
Thanks for the fast turn-around!!

Original comment by awolf...@gmail.com on 30 Jan 2014 at 7:13

GoogleCodeExporter commented 8 years ago 
Works for me as well. Thanks!

Original comment by jona...@gmail.com on 30 Jan 2014 at 8:42