search

hadiasghari / pyasn

Python IP address to Autonomous System Number lookup module. (Supports fast local lookups, and historical lookups using archived BGP dumps.)
Other
294 stars 72 forks source link

fix pyasn __init__ to work with py27 #31

Closed sanketsharma411 closed 8 years ago

sanketsharma411 commented 8 years ago

In commit https://github.com/hadiasghari/pyasn/commit/65b9576a35f4ef2ee84da6c925da851e07dc458b, open(..., encoding=...) was used which would not work with python < 3. Instead as suggested codecs.open() should be used, which would be consistent with python 2.7 and 3.

sebix commented 8 years ago

@hadiasghari could you cherry-pick this commit?

hadiasghari commented 8 years ago

Thanks @sanketsharma411 @sebix , will check it this weekend.

hadiasghari commented 8 years ago

@sebix alright, done, please reopen if there is an issue. @sanketsharma411 thank you for the patch!