search

hadiasghari / pyasn

Python IP address to Autonomous System Number lookup module. (Supports fast local lookups, and historical lookups using archived BGP dumps.)
Other
292 stars 72 forks source link

compilation error on Windows #47

Closed gsankara closed 7 years ago

gsankara commented 7 years ago

C:\Users\abcd\AppData\Local\Programs\Common\Microsoft\Visual C++ for Python\9. 0\VC\Bin\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -IC:\Users\abcd\tracert\pyasn-1.6.0b1\pyasn -Ic:\Python27\include -Ic:\Python27\PC /Tcpyasn/pyasn_radix.c /Fobuild\temp.win32-2.7\Release\pyasn /pyasn_radix.obj pyasn_radix.c pyasn/pyasn_radix.c(662) : error C2143: syntax error : missing ';' before 'type'

When I moved the corresponding declaration from line 662 to as the first statement within the block i.e. 656, it got compiled successfully. char buf[512], p1, p2;

hadiasghari commented 7 years ago

Hi @gsankara , thanks for this. Can you do a pull request with your fix? I can then merge it ot the main code.

gsankara commented 7 years ago

Sorry @hadiasghari. I am not familiar with the procedure you are suggesting.

regs Ganesh

On Mon, Jul 24, 2017 at 7:08 PM, Hadi Asghari notifications@github.com wrote:

Hi @gsankara https://github.com/gsankara , thanks for this. Can you do a pull request with your fix? I can then merge it ot the main code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hadiasghari/pyasn/issues/47#issuecomment-317425144, or mute the thread https://github.com/notifications/unsubscribe-auth/ATysXM3Kw7XxxJzFFMKx7u0q82842Noqks5sRJ5jgaJpZM4OgEs_ .

hadiasghari commented 7 years ago

It's rather simple: you fork pyasn on github, make your changes and commit to your forked repository, then do a pull request through the github interface so I can merge it. I can then test+merge it.

gsankara commented 7 years ago

@hadiasghari Thanks, done. Please check if it is okay.

regs Ganesh

On Mon, Jul 24, 2017 at 8:09 PM, Hadi Asghari notifications@github.com wrote:

It's rather simple: you fork pyasn on github, make your changes and commit to your forked repository, then do a pull request through the github interface so I can merge it. I can then test+merge it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hadiasghari/pyasn/issues/47#issuecomment-317443987, or mute the thread https://github.com/notifications/unsubscribe-auth/ATysXPpbf3OSryQg5n2yV2sEUh6_W0JVks5sRKysgaJpZM4OgEs_ .

hadiasghari commented 7 years ago

Thank you, I've merged your changes in master!